Move charset information before any content #1292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the rendering of non-ASCII characters in the OpenGraph embeds. For example, 🎉🎉🎉 would render as 🎉🎉🎉.
|
I wasn't seeing this issue in my browser (Safari), but it seems like a safe change. |
|
@SethTisue This doesn't show up in browsers as they correctly interpret the charset coming after the OGP data, however Discord's crawler does not. (I guess it's not really a crawler, but I don't know what to call it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the rendering of non-ASCII characters in the OpenGraph embeds. For example, 🎉🎉🎉 is rendering as 🎉🎉🎉.